我运行 instruments 工具并发现一些内存泄漏，但我不知道如何处理。我正在使用 ARC!

这是我的代码:

+ (MARequest *)requestImageThumb:(NSString *)imageName
                      object:(NSInteger)objectId {
   NSString* urlString = [NSString stringWithFormat:@"%@/%@", kBaseImageThumbURL, imageName];

   LogTrace(@"Creating image thumb request for file %@", imageName);

   //Here starts the leak!!
   return [MARequest createWithURL:[NSURL URLWithString:urlString]
                           type:REQUEST_TYPE_GET_IMAGE];
}


+ (MARequest *)createWithURL:(NSURL *)url
                    type:(NSInteger)type {

   MARequest* r = [[MARequest alloc] init];

   r.url = url;
   r.requestType = type;
   r.responseData = [[NSMutableData alloc] init];
   r.connection = [[NSURLConnection alloc] initWithRequest:[NSURLRequest requestWithURL:r.url]
                                               delegate:r
                                       startImmediately:NO];

   return r;
}

这是我的 NSURLConnectionDelegate

#pragma mark - NSURLConnectionDelegate
- (void)connection:(NSURLConnection *)connection didReceiveResponse:(NSURLResponse *)response {
   LogTrace(@"request %@: didReceiveResponse", self.url);
   [self.responseData setLength:0];
}

- (void)connection:(NSURLConnection *)connection didReceiveData:(NSData *)data {
   LogTrace(@"request %@: didReceiveData, %d bytes", self.url, data.length);

   [self.responseData appendData:data];
}

- (void)connection:(NSURLConnection *)connection didFailWithError:(NSError *)error {
   LogTrace(@"request %@: didFailWithError: %@", self.url, [error description]);

   self.connection = nil;
   self.failed = YES;

[self invokeAction];
}

- (void)connectionDidFinishLoading:(NSURLConnection *)connection {
   LogTrace(@"request %@: connectionDidFinishLoading, %d bytes", self.url, [self.responseData length]);
   self.connection = nil;

   [self invokeAction];
}

编辑:

我现在将我的代码更改为此，但遗憾的是它仍然给我内存泄漏....

+ (MARequest *)requestImageThumb:(NSString *)imageName
                      object:(NSInteger)objectId {
    NSString* urlString = [NSString stringWithFormat:@"%@/%@", kBaseImageThumbURL, imageName];

    LogTrace(@"Creating image thumb request for file %@", imageName);

    return [MARequest requestWithURL:[NSURL URLWithString:urlString]
                           type:REQUEST_TYPE_GET_IMAGE];
}

+ (MARequest *)requestWithURL:(NSURL *)url
                    type:(NSInteger)type {

   MARequest* r = [[MARequest alloc] init];

   r.url = url;
   r.requestType = type;
   r.responseData = [[NSMutableData alloc] init];
   r.connection = [[NSURLConnection alloc] initWithRequest:[NSURLRequest requestWithURL:r.url]
                                               delegate:r
                                       startImmediately:NO];



   return r;
}

最佳答案

编辑:更改后，泄漏的解释如下:

您的 GFRequest 对象和 NSURLConnection 对象之间存在循环依赖关系，因此无法正确解除分配。实际上，您正在将 GFRequest 的连接属性设置为 NSURLConnection 实例:

   r.connection = [[NSURLConnection alloc] initWithRequest:[NSURLRequest requestWithURL:r.url]

同时还使 r 成为 NSURLConnection 的委托(delegate):

             delegate:r

发生的事情是 NSURLConnection's delegate does a retain on its delegate ，这会导致依赖循环。

不过，我没有看到打破依赖关系并保持当前设计的简单方法。

您可以简单地避免在请求中存储您的连接，或者您不能将请求用作连接的委托(delegate)。可能，您应该考虑子类化 NSURLConnection 的可能性，并让它充当自身的委托(delegate)。

旧答案:

外部方法名和内部方法名不匹配:

+ (MARequest *)requestImageThumb:(NSString *)imageName
…
   return [MARequest createWithURL:[NSURL URLWithString:urlString]

对于静态分析器，它们在对象所有权方面具有不同的语义。

将第一个替换为:

+ (MARequest *)createRequestImageThumb:(NSString *)imageName

或第二个:

   return [MARequest requestWithURL:[NSURL URLWithString:urlString]

取决于哪种语义适合您的情况。

关于ios - NSURLConnection 内存泄漏，我们在Stack Overflow上找到一个类似的问题： https://stackoverflow.com/questions/24368875/