它有效，但也许你们中有人知道是否有更好的方法来实现我正在尝试做的事情:

<?php if ($md_options->mobileversion == true) {;?><!-- Ok Mobile mode is ON -->
    <?php if (detectdevice() != 'true') {;?><!-- Now if we are NOT on a mobile let's start! -->
        <?php if ((is_single()) && ($metaBox == true)) {;?><!-- If is Single and 360Panorama is set let's show panorama -->
            <?php include('360ok.php');?><!-- Houston we have a panorama! -->
        <?php } elseif ((!is_single()) || ($metaBox != true)){;?><!-- Each page that hasn't set a panorama will check... -->
            <?php if ($md_options->slideorvideo == 'true') {;?><!-- Do you want to show a slideshow? -->
                <?php include('slideshowhome.php');?><!-- What a nice slideshow! -->
            <?php } elseif ($md_options->slideorvideo == 'false') {;?><!-- You prefer a video? let's show it! -->
                <?php include("video/video.php");?>
            <?php };?><!-- Closes video option -->
            <?php if ($md_options->slivideoposition != 'center'){;?><!-- Let's show the post next to the video or slideshow if it is possible -->
                <?php include('postheader.php');?>
            <?php };?><!-- Closes POSTHEADER -->
        <?php };?><!-- Close Else if !is_single || $metabox != true -->
    <?php };?><!-- Closes the function that checks if we are on a mobile or not -->
<?php } elseif ($md_options->mobileversion != true) {;?><!-- Closes mobile version ON/OFF -->
    <?php if ((is_single()) && ($metaBox == true)) {;?><!-- If is Single and 360Panorama is set let's show panorama -->
        <?php include('360ok.php');?><!-- Houston we have a panorama! -->
    <?php } elseif ((!is_single()) || ($metaBox != true)){;?><!-- Each page that hasn't set a panorama will check... -->
        <?php if ($md_options->slideorvideo == 'true') {;?><!-- Do you want to show a slideshow? -->
            <?php include('slideshowhome.php');?><!-- What a nice slideshow! -->
        <?php } elseif ($md_options->slideorvideo == 'false') {;?><!-- You prefer a video? let's show it! -->
            <?php include("video/video.php");?>
        <?php };?><!-- Closes video option -->
        <?php if ($md_options->slivideoposition != 'center'){;?><!-- Let's show the post next to the video or slideshow if it is possible -->
            <?php include('postheader.php');?>
        <?php };?><!-- Closes POSTHEADER -->
    <?php };?><!-- Close Else if !is_single || $metabox != true -->
<?php };?><!-- If mobile mode is OFF this closes the IF -->

相同的代码(没有多余的 <?php ?> 标签):

<?php

if ($md_options->mobileversion == true) {
    if (detectdevice() != 'true') {
        if ((is_single()) && ($metaBox == true)) {
            include('360ok.php')
        } elseif ((!is_single()) || ($metaBox != true)) {
            if ($md_options->slideorvideo == 'true') {
                include('slideshowhome.php');
            } elseif ($md_options->slideorvideo == 'false') {
                include("video/video.php");
            }
            if ($md_options->slivideoposition != 'center') {
                include('postheader.php');
            }
        }
    }
} elseif ($md_options->mobileversion != true) {
    if ((is_single()) && ($metaBox == true)) {
        include('360ok.php');
    } elseif ((!is_single()) || ($metaBox != true)) {
        if ($md_options->slideorvideo == 'true') {
            include('slideshowhome.php');
        } elseif ($md_options->slideorvideo == 'false') {
            include("video/video.php");
        }
        if ($md_options->slivideoposition != 'center') {
            include('postheader.php');
        }
    }
}

?>

有没有更快的方法到达同一点？

最佳答案

首先，?>关闭标签表示 ; .所以写?>类似于写; ?> .添加另一个 ;之前它类似于写 ;; ?> .

您可以做很多事情来改善这一点。

• 删除 <?php ... ?> .随便开一个<?php标记并用 ?> 关闭它在写完整个逻辑之后。
• 替换 if (something == true) { ... } else if (something != true) { ... }逻辑与 if (something) { ... } else { ... }
• 删除多余的括号。
• 将逻辑提取到组成部分并尝试简化它。
• 通过简单地存储其返回值来停止一遍又一遍地调用相同的函数。

据我所知，代码的目的是在某些情况下包括以下之一:“360ok.php”、“slideshowhome.php”或“video/video.php”和“postheader.php”。您可以以此为基础的逻辑。

简化逻辑使其更具可读性:

<?php

if ($md_options->mobileversion) {
    if (detectdevice() != 'true') {
        if (is_single() && $metaBox) {
            include('360ok.php');
        } else {
            if ($md_options->slideorvideo == 'true') {
                include('slideshowhome.php');
            } elseif ($md_options->slideorvideo == 'false') {
                include('video/video.php');
            }
            if ($md_options->slivideoposition != 'center') {
                include('postheader.php');
            }
        }
    }
} else {
    if (is_single() && $metaBox) {
        include('360ok.php');
    } else {
        if ($md_options->slideorvideo == 'true') {
            include('slideshowhome.php');
        } elseif ($md_options->slideorvideo == 'false') {
            include('video/video.php');
        }
        if ($md_options->slivideoposition != 'center') {
            include('postheader.php');
        }
    }
}

?>

据此我了解到有2种情况:

• 如果$md_options->mobileversion和 detectdevice() != 'true'
• 如果不是$md_options->mobileversion .

在每种情况下，逻辑都是相同的，因此我们可以进一步简化它:

if (!$md_options->mobileversion || detectdevice() != 'true') {
    if (is_single() && $metaBox) {
        include('360ok.php');
    } else {
        if ($md_options->slideorvideo == 'true') {
            include('slideshowhome.php');
        } elseif ($md_options->slideorvideo == 'false') {
            include('video/video.php');
        }
        if ($md_options->slivideoposition != 'center') {
            include('postheader.php');
        }
    }
}

此外，如果 $md_options->slideorvideo 的值可以是字符串 'true'或 'false' ，那么我们可以进一步简化它:

if (!$md_options->mobileversion || detectdevice() != 'true') {
    if (is_single() && $metaBox) {
        include('360ok.php');
    } else {
        if ($md_options->slideorvideo == 'true') {
            include('slideshowhome.php');
        } else {
            include('video/video.php');
        }
        if ($md_options->slivideoposition != 'center') {
            include('postheader.php');
        }
    }
}

清晰简洁的代码通常比过于冗长的代码更具可读性和可维护性。此外，您没有理由不将注释作为 PHP 注释包含在内，而只包含暗示包含某个文件的原因的相关注释。例如:

// only do this if mobile mode is ON and we're not on a mobile,
// or if mobile mode is OFF
if (!$md_options->mobileversion || detectdevice() != 'true') {
    if (is_single() && $metaBox) {
        // if is single and 360 panorama is set, let's show panorama
        include('360ok.php');
    } else {
        // show the slideshow or the video, according to the user's preferences
        if ($md_options->slideorvideo == 'true') {
            include('slideshowhome.php');
        } else {
            include('video/video.php');
        }

        // if possible, let's also show the post next to it
        if ($md_options->slivideoposition != 'center') {
            include('postheader.php');
        }
    }
}

如您所见，实际上不需要 else 旁边的额外注释例如，因为您可以流利地阅读代码和相关注释。任何额外的注释只会妨碍并降低重要注释的可读性。

关于php - 有没有更好的方法来设计这个 PHP 函数？，我们在Stack Overflow上找到一个类似的问题： https://stackoverflow.com/questions/8029336/