我正在开发一个 slack 机器人作为我的第一个 golang 项目,虽然这个特定的机器人命令的功能很好,但它可能会随机出现 panic 并抛出错误。
我能够确定我正在进行数据竞赛,特别是我的两个 go 例程。但是,我很难确定如何修补它们,或者执行互斥锁是否是处理共享变量的正确方法。
我正在尝试确定问题是否出在我的result 变量上,该变量被分成多个 channel ,每个 channel 都由 go 例程处理,或者是否是os.exec 包使用我的缓冲区变量来运行 stdout 和 stderr 修改的命令。
下面是代码和数据竞争示例。
package reboot
import (
"bytes"
"encoding/json"
"fmt"
"io/ioutil"
"log"
"os/exec"
"regexp"
)
// to handle json keys
type rebootObject struct {
Name string
Command string
}
var (
fileNotFound = "config file not found"
cmdNotFound = "Error finding command argument"
)
// *bot.Cmd is the first arg to be passed to the bot
// bot.CmdResultV3 wants message from go routine and done = true
func Reboot(command *bot.Cmd) (result bot.CmdResultV3, err error) {
result = bot.CmdResultV3{Message: make(chan string), Done: make(chan bool, 1)}
// load json config file with names/commands
filePath := "./plugins/reboot/config.json"
file, err1 := ioutil.ReadFile(filePath)
if err1 != nil {
bot.Reply(command.Channel, fileNotFound, command.User)
}
var scriptParse []rebootObject
//userinput := "box4535345346" // faking user input
userinput := command.Args[0] // real one
err2 := json.Unmarshal(file, &scriptParse)
if err2 != nil {
fmt.Println("error:", err2)
bot.Reply(command.Channel, fileNotFound, command.User)
}
//strip numbers off input to match json key
reg, err := regexp.Compile("[^a-zA-Z]+")
if err != nil {
log.Fatal(err)
}
// loop through json file to find the match of user input to json name key
cmdFound := false
for k := range scriptParse {
newinput := reg.ReplaceAllString(userinput, "")
// keep running for loop until names do match
if scriptParse[k].Name != newinput {
continue
}
cmdFound = true
cmd := exec.Command("/bin/bash", "-c", scriptParse[k].Command)
var b bytes.Buffer
cmd.Stdout = &b
cmd.Stderr = &b
err = cmd.Start()
if err != nil {
return
}
done := false
go func() {
cmd.Wait()
done = true
result.Done <- true
}()
go func() {
for {
line, _ := b.ReadString('\n')
if line != "" {
result.Message <- line
}
if done {
close(result.Message)
break
}
}
}()
}
if cmdFound == false {
result.Done <- true
bot.Reply(command.Channel, cmdNotFound, command.User)
}
return result, nil
}
数据竞赛:
==================
WARNING: DATA RACE
Read at 0x00c420582558 by goroutine 37:
bytes.(*Buffer).readSlice()
/usr/local/go/src/bytes/buffer.go:421 +0x48
bytes.(*Buffer).ReadString()
/usr/local/go/src/bytes/buffer.go:440 +0x45
github.com/owner/gobot/plugins/reboot.Reboot.func2()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:79 +0x41
Previous write at 0x00c420582558 by goroutine 35:
bytes.(*Buffer).ReadFrom()
/usr/local/go/src/bytes/buffer.go:92 +0x608
io.copyBuffer()
/usr/local/go/src/io/io.go:386 +0x348
io.Copy()
/usr/local/go/src/io/io.go:362 +0x7e
os/exec.(*Cmd).writerDescriptor.func1()
/usr/local/go/src/os/exec/exec.go:264 +0x68
os/exec.(*Cmd).Start.func1()
/usr/local/go/src/os/exec/exec.go:380 +0x34
Goroutine 37 (running) created at:
github.com/owner/gobot/plugins/reboot.Reboot()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:77 +0x885
github.com/owner/gobot/bot.(*Bot).handleCmd()
/Users/macowner/go/src/github.com/owner/gobot/bot/cmd.go:240 +0x13b
github.com/owner/gobot/bot.(*Bot).MessageReceived()
/Users/macowner/go/src/github.com/owner/gobot/bot/bot.go:101 +0x5a8
github.com/owner/gobot/bot.Run()
/Users/macowner/go/src/github.com/owner/gobot/bot/reply.go:142 +0xdb3
main.main()
/Users/macowner/go/src/github.com/owner/gobot/main.go:46 +0x9b0
Goroutine 35 (running) created at:
os/exec.(*Cmd).Start()
/usr/local/go/src/os/exec/exec.go:379 +0xa6b
github.com/owner/gobot/plugins/reboot.Reboot()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:67 +0x7c8
github.com/owner/gobot/bot.(*Bot).handleCmd()
/Users/macowner/go/src/github.com/owner/gobot/bot/cmd.go:240 +0x13b
github.com/owner/gobot/bot.(*Bot).MessageReceived()
/Users/macowner/go/src/github.com/owner/gobot/bot/bot.go:101 +0x5a8
github.com/owner/gobot/bot.Run()
/Users/macowner/go/src/github.com/owner/gobot/bot/reply.go:142 +0xdb3
main.main()
/Users/macowner/go/src/github.com/owner/gobot/main.go:46 +0x9b0
==================
==================
WARNING: DATA RACE
Read at 0x00c420582540 by goroutine 37:
bytes.(*Buffer).readSlice()
/usr/local/go/src/bytes/buffer.go:421 +0x62
bytes.(*Buffer).ReadString()
/usr/local/go/src/bytes/buffer.go:440 +0x45
github.com/owner/gobot/plugins/reboot.Reboot.func2()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:79 +0x41
Previous write at 0x00c420582540 by goroutine 35:
bytes.(*Buffer).ReadFrom()
/usr/local/go/src/bytes/buffer.go:91 +0x5d0
io.copyBuffer()
/usr/local/go/src/io/io.go:386 +0x348
io.Copy()
/usr/local/go/src/io/io.go:362 +0x7e
os/exec.(*Cmd).writerDescriptor.func1()
/usr/local/go/src/os/exec/exec.go:264 +0x68
os/exec.(*Cmd).Start.func1()
/usr/local/go/src/os/exec/exec.go:380 +0x34
Goroutine 37 (running) created at:
github.com/owner/gobot/plugins/reboot.Reboot()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:77 +0x885
github.com/owner/gobot/bot.(*Bot).handleCmd()
/Users/macowner/go/src/github.com/owner/gobot/bot/cmd.go:240 +0x13b
github.com/owner/gobot/bot.(*Bot).MessageReceived()
/Users/macowner/go/src/github.com/owner/gobot/bot/bot.go:101 +0x5a8
github.com/owner/gobot/bot.Run()
/Users/macowner/go/src/github.com/owner/gobot/bot/reply.go:142 +0xdb3
main.main()
/Users/macowner/go/src/github.com/owner/gobot/main.go:46 +0x9b0
Goroutine 35 (running) created at:
os/exec.(*Cmd).Start()
/usr/local/go/src/os/exec/exec.go:379 +0xa6b
github.com/owner/gobot/plugins/reboot.Reboot()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:67 +0x7c8
github.com/owner/gobot/bot.(*Bot).handleCmd()
/Users/macowner/go/src/github.com/owner/gobot/bot/cmd.go:240 +0x13b
github.com/owner/gobot/bot.(*Bot).MessageReceived()
/Users/macowner/go/src/github.com/owner/gobot/bot/bot.go:101 +0x5a8
github.com/owner/gobot/bot.Run()
/Users/macowner/go/src/github.com/owner/gobot/bot/reply.go:142 +0xdb3
main.main()
/Users/macowner/go/src/github.com/owner/gobot/main.go:46 +0x9b0
==================
==================
WARNING: DATA RACE
Write at 0x00c420582560 by goroutine 37:
bytes.(*Buffer).readSlice()
/usr/local/go/src/bytes/buffer.go:429 +0x186
bytes.(*Buffer).ReadString()
/usr/local/go/src/bytes/buffer.go:440 +0x45
github.com/owner/gobot/plugins/reboot.Reboot.func2()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:79 +0x41
Previous write at 0x00c420582560 by goroutine 35:
bytes.(*Buffer).ReadFrom()
/usr/local/go/src/bytes/buffer.go:191 +0x5f
io.copyBuffer()
/usr/local/go/src/io/io.go:386 +0x348
io.Copy()
/usr/local/go/src/io/io.go:362 +0x7e
os/exec.(*Cmd).writerDescriptor.func1()
/usr/local/go/src/os/exec/exec.go:264 +0x68
os/exec.(*Cmd).Start.func1()
/usr/local/go/src/os/exec/exec.go:380 +0x34
Goroutine 37 (running) created at:
github.com/owner/gobot/plugins/reboot.Reboot()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:77 +0x885
github.com/owner/gobot/bot.(*Bot).handleCmd()
/Users/macowner/go/src/github.com/owner/gobot/bot/cmd.go:240 +0x13b
github.com/owner/gobot/bot.(*Bot).MessageReceived()
/Users/macowner/go/src/github.com/owner/gobot/bot/bot.go:101 +0x5a8
github.com/owner/gobot/bot.Run()
/Users/macowner/go/src/github.com/owner/gobot/bot/reply.go:142 +0xdb3
main.main()
/Users/macowner/go/src/github.com/owner/gobot/main.go:46 +0x9b0
Goroutine 35 (running) created at:
os/exec.(*Cmd).Start()
/usr/local/go/src/os/exec/exec.go:379 +0xa6b
github.com/owner/gobot/plugins/reboot.Reboot()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:67 +0x7c8
github.com/owner/gobot/bot.(*Bot).handleCmd()
/Users/macowner/go/src/github.com/owner/gobot/bot/cmd.go:240 +0x13b
github.com/owner/gobot/bot.(*Bot).MessageReceived()
/Users/macowner/go/src/github.com/owner/gobot/bot/bot.go:101 +0x5a8
github.com/owner/gobot/bot.Run()
/Users/macowner/go/src/github.com/owner/gobot/bot/reply.go:142 +0xdb3
main.main()
/Users/macowner/go/src/github.com/owner/gobot/main.go:46 +0x9b0
==================
==================
WARNING: DATA RACE
Read at 0x00c42014cc00 by goroutine 37:
runtime.slicebytetostring()
/usr/local/go/src/runtime/string.go:72 +0x0
bytes.(*Buffer).ReadString()
/usr/local/go/src/bytes/buffer.go:441 +0x84
github.com/owner/gobot/plugins/reboot.Reboot.func2()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:79 +0x41
Previous write at 0x00c42014cc00 by goroutine 35:
internal/race.WriteRange()
/usr/local/go/src/internal/race/race.go:49 +0x42
syscall.Read()
/usr/local/go/src/syscall/syscall_unix.go:165 +0x9a
internal/poll.(*FD).Read()
/usr/local/go/src/internal/poll/fd_unix.go:122 +0x1a0
os.(*File).read()
/usr/local/go/src/os/file_unix.go:216 +0x70
os.(*File).Read()
/usr/local/go/src/os/file.go:103 +0x8e
bytes.(*Buffer).ReadFrom()
/usr/local/go/src/bytes/buffer.go:209 +0x1dd
io.copyBuffer()
/usr/local/go/src/io/io.go:386 +0x348
io.Copy()
/usr/local/go/src/io/io.go:362 +0x7e
os/exec.(*Cmd).writerDescriptor.func1()
/usr/local/go/src/os/exec/exec.go:264 +0x68
os/exec.(*Cmd).Start.func1()
/usr/local/go/src/os/exec/exec.go:380 +0x34
Goroutine 37 (running) created at:
github.com/owner/gobot/plugins/reboot.Reboot()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:77 +0x885
github.com/owner/gobot/bot.(*Bot).handleCmd()
/Users/macowner/go/src/github.com/owner/gobot/bot/cmd.go:240 +0x13b
github.com/owner/gobot/bot.(*Bot).MessageReceived()
/Users/macowner/go/src/github.com/owner/gobot/bot/bot.go:101 +0x5a8
github.com/owner/gobot/bot.Run()
/Users/macowner/go/src/github.com/owner/gobot/bot/reply.go:142 +0xdb3
main.main()
/Users/macowner/go/src/github.com/owner/gobot/main.go:46 +0x9b0
Goroutine 35 (running) created at:
os/exec.(*Cmd).Start()
/usr/local/go/src/os/exec/exec.go:379 +0xa6b
github.com/owner/gobot/plugins/reboot.Reboot()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:67 +0x7c8
github.com/owner/gobot/bot.(*Bot).handleCmd()
/Users/macowner/go/src/github.com/owner/gobot/bot/cmd.go:240 +0x13b
github.com/owner/gobot/bot.(*Bot).MessageReceived()
/Users/macowner/go/src/github.com/owner/gobot/bot/bot.go:101 +0x5a8
github.com/owner/gobot/bot.Run()
/Users/macowner/go/src/github.com/owner/gobot/bot/reply.go:142 +0xdb3
main.main()
/Users/macowner/go/src/github.com/owner/gobot/main.go:46 +0x9b0
==================
==================
WARNING: DATA RACE
Read at 0x00c4202d2600 by goroutine 37:
runtime.slicebytetostring()
/usr/local/go/src/runtime/string.go:72 +0x0
bytes.(*Buffer).ReadString()
/usr/local/go/src/bytes/buffer.go:441 +0x84
github.com/owner/gobot/plugins/reboot.Reboot.func2()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:79 +0x41
Previous write at 0x00c4202d2600 by goroutine 35:
runtime.slicecopy()
/usr/local/go/src/runtime/slice.go:160 +0x0
bytes.(*Buffer).ReadFrom()
/usr/local/go/src/bytes/buffer.go:205 +0x4b2
io.copyBuffer()
/usr/local/go/src/io/io.go:386 +0x348
io.Copy()
/usr/local/go/src/io/io.go:362 +0x7e
os/exec.(*Cmd).writerDescriptor.func1()
/usr/local/go/src/os/exec/exec.go:264 +0x68
os/exec.(*Cmd).Start.func1()
/usr/local/go/src/os/exec/exec.go:380 +0x34
Goroutine 37 (running) created at:
github.com/owner/gobot/plugins/reboot.Reboot()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:77 +0x885
github.com/owner/gobot/bot.(*Bot).handleCmd()
/Users/macowner/go/src/github.com/owner/gobot/bot/cmd.go:240 +0x13b
github.com/owner/gobot/bot.(*Bot).MessageReceived()
/Users/macowner/go/src/github.com/owner/gobot/bot/bot.go:101 +0x5a8
github.com/owner/gobot/bot.Run()
/Users/macowner/go/src/github.com/owner/gobot/bot/reply.go:142 +0xdb3
main.main()
/Users/macowner/go/src/github.com/owner/gobot/main.go:46 +0x9b0
Goroutine 35 (running) created at:
os/exec.(*Cmd).Start()
/usr/local/go/src/os/exec/exec.go:379 +0xa6b
github.com/owner/gobot/plugins/reboot.Reboot()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:67 +0x7c8
github.com/owner/gobot/bot.(*Bot).handleCmd()
/Users/macowner/go/src/github.com/owner/gobot/bot/cmd.go:240 +0x13b
github.com/owner/gobot/bot.(*Bot).MessageReceived()
/Users/macowner/go/src/github.com/owner/gobot/bot/bot.go:101 +0x5a8
github.com/owner/gobot/bot.Run()
/Users/macowner/go/src/github.com/owner/gobot/bot/reply.go:142 +0xdb3
main.main()
/Users/macowner/go/src/github.com/owner/gobot/main.go:46 +0x9b0
==================
==================
WARNING: DATA RACE
Write at 0x00c4202008c8 by goroutine 36:
github.com/owner/gobot/plugins/reboot.Reboot.func1()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:74 +0x4d
Previous read at 0x00c4202008c8 by goroutine 37:
github.com/owner/gobot/plugins/reboot.Reboot.func2()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:83 +0x61
Goroutine 36 (running) created at:
github.com/owner/gobot/plugins/reboot.Reboot()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:72 +0x846
github.com/owner/gobot/bot.(*Bot).handleCmd()
/Users/macowner/go/src/github.com/owner/gobot/bot/cmd.go:240 +0x13b
github.com/owner/gobot/bot.(*Bot).MessageReceived()
/Users/macowner/go/src/github.com/owner/gobot/bot/bot.go:101 +0x5a8
github.com/owner/gobot/bot.Run()
/Users/macowner/go/src/github.com/owner/gobot/bot/reply.go:142 +0xdb3
main.main()
/Users/macowner/go/src/github.com/owner/gobot/main.go:46 +0x9b0
Goroutine 37 (running) created at:
github.com/owner/gobot/plugins/reboot.Reboot()
/Users/macowner/go/src/github.com/owner/gobot/plugins/reboot/reboot.go:77 +0x885
github.com/owner/gobot/bot.(*Bot).handleCmd()
/Users/macowner/go/src/github.com/owner/gobot/bot/cmd.go:240 +0x13b
github.com/owner/gobot/bot.(*Bot).MessageReceived()
/Users/macowner/go/src/github.com/owner/gobot/bot/bot.go:101 +0x5a8
github.com/owner/gobot/bot.Run()
/Users/macowner/go/src/github.com/owner/gobot/bot/reply.go:142 +0xdb3
main.main()
/Users/macowner/go/src/github.com/owner/gobot/main.go:46 +0x9b0
==================
最佳答案
第一个 goroutine,从 cmd.Wait() 开始,正在写入缓冲区 b 而另一个 goroutine,从 line, _ := b.ReadString('\n') 正在读取它。这就是数据竞赛发生的原因。修改代码,执行完成后只读取执行结果。
关于go - 使用 slack bot 处理多个数据竞争,我们在Stack Overflow上找到一个类似的问题: https://stackoverflow.com/questions/48769644/
我正在学习如何使用Nokogiri,根据这段代码我遇到了一些问题:require'rubygems'require'mechanize'post_agent=WWW::Mechanize.newpost_page=post_agent.get('http://www.vbulletin.org/forum/showthread.php?t=230708')puts"\nabsolutepathwithtbodygivesnil"putspost_page.parser.xpath('/html/body/div/div/div/div/div/table/tbody/tr/td/div
我有一个Ruby程序,它使用rubyzip压缩XML文件的目录树。gem。我的问题是文件开始变得很重,我想提高压缩级别,因为压缩时间不是问题。我在rubyzipdocumentation中找不到一种为创建的ZIP文件指定压缩级别的方法。有人知道如何更改此设置吗?是否有另一个允许指定压缩级别的Ruby库? 最佳答案 这是我通过查看rubyzip内部创建的代码。level=Zlib::BEST_COMPRESSIONZip::ZipOutputStream.open(zip_file)do|zip|Dir.glob("**/*")d
类classAprivatedeffooputs:fooendpublicdefbarputs:barendprivatedefzimputs:zimendprotecteddefdibputs:dibendendA的实例a=A.new测试a.foorescueputs:faila.barrescueputs:faila.zimrescueputs:faila.dibrescueputs:faila.gazrescueputs:fail测试输出failbarfailfailfail.发送测试[:foo,:bar,:zim,:dib,:gaz].each{|m|a.send(m)resc
很好奇,就使用rubyonrails自动化单元测试而言,你们正在做什么?您是否创建了一个脚本来在cron中运行rake作业并将结果邮寄给您?git中的预提交Hook?只是手动调用?我完全理解测试,但想知道在错误发生之前捕获错误的最佳实践是什么。让我们理所当然地认为测试本身是完美无缺的,并且可以正常工作。下一步是什么以确保他们在正确的时间将可能有害的结果传达给您? 最佳答案 不确定您到底想听什么,但是有几个级别的自动代码库控制:在处理某项功能时,您可以使用类似autotest的内容获得关于哪些有效,哪些无效的即时反馈。要确保您的提
假设我做了一个模块如下:m=Module.newdoclassCendend三个问题:除了对m的引用之外,还有什么方法可以访问C和m中的其他内容?我可以在创建匿名模块后为其命名吗(就像我输入“module...”一样)?如何在使用完匿名模块后将其删除,使其定义的常量不再存在? 最佳答案 三个答案:是的,使用ObjectSpace.此代码使c引用你的类(class)C不引用m:c=nilObjectSpace.each_object{|obj|c=objif(Class===objandobj.name=~/::C$/)}当然这取决于
我正在尝试使用ruby和Savon来使用网络服务。测试服务为http://www.webservicex.net/WS/WSDetails.aspx?WSID=9&CATID=2require'rubygems'require'savon'client=Savon::Client.new"http://www.webservicex.net/stockquote.asmx?WSDL"client.get_quotedo|soap|soap.body={:symbol=>"AAPL"}end返回SOAP异常。检查soap信封,在我看来soap请求没有正确的命名空间。任何人都可以建议我
关闭。这个问题是opinion-based.它目前不接受答案。想要改进这个问题?更新问题,以便editingthispost可以用事实和引用来回答它.关闭4年前。Improvethisquestion我想在固定时间创建一系列低音和高音调的哔哔声。例如:在150毫秒时发出高音调的蜂鸣声在151毫秒时发出低音调的蜂鸣声200毫秒时发出低音调的蜂鸣声250毫秒的高音调蜂鸣声有没有办法在Ruby或Python中做到这一点?我真的不在乎输出编码是什么(.wav、.mp3、.ogg等等),但我确实想创建一个输出文件。
Rails2.3可以选择随时使用RouteSet#add_configuration_file添加更多路由。是否可以在Rails3项目中做同样的事情? 最佳答案 在config/application.rb中:config.paths.config.routes在Rails3.2(也可能是Rails3.1)中,使用:config.paths["config/routes"] 关于ruby-on-rails-Rails3中的多个路由文件,我们在StackOverflow上找到一个类似的问题
我在我的项目目录中完成了compasscreate.和compassinitrails。几个问题:我已将我的.sass文件放在public/stylesheets中。这是放置它们的正确位置吗?当我运行compasswatch时,它不会自动编译这些.sass文件。我必须手动指定文件:compasswatchpublic/stylesheets/myfile.sass等。如何让它自动运行?文件ie.css、print.css和screen.css已放在stylesheets/compiled。如何在编译后不让它们重新出现的情况下删除它们?我自己编译的.sass文件编译成compiled/t
我想将html转换为纯文本。不过,我不想只删除标签,我想智能地保留尽可能多的格式。为插入换行符标签,检测段落并格式化它们等。输入非常简单,通常是格式良好的html(不是整个文档,只是一堆内容,通常没有anchor或图像)。我可以将几个正则表达式放在一起,让我达到80%,但我认为可能有一些现有的解决方案更智能。 最佳答案 首先,不要尝试为此使用正则表达式。很有可能你会想出一个脆弱/脆弱的解决方案,它会随着HTML的变化而崩溃,或者很难管理和维护。您可以使用Nokogiri快速解析HTML并提取文本:require'nokogiri'h